Shrinkdesc 92 #53
Open
Shrinkdesc 92 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Andrew and Jesper The cli maven plugin is running. The plugin generates the descriptors according the passed parameters. You can execute the transformation like this example: org.jboss.shrinkwrap.descriptors shrinkwrap-descriptors-cli-plugin ${project.version} transform install transform ${project.build.directory}/../../cli/src/test/resources/xml/schemasIronJacamar.xml ${project.build.directory}/../../cli-test/src/main/java ${project.build.directory}/../../cli-test/src/test/java ${project.build.directory}/cli trueNote, the can be empty, then no test classes are generated. Not done so far are:
Let me know how to proceed. Regards, |
…ector_1_0.dtd as converted xsd
…ector_1_0.dtd as converted xsd
…n module; service files are created optionally
…d are .gitignored
…iptors-metadata-parser, which it does not understand
|
Hi Andrew If Bartosz looks at the source code, then it is better to commit everything. So, the latest version includes the following features:
Some general comments about the plugin. The plugin will support much more descriptor out of the box because there are no hacks any more implemented covering a particular descriptor definition. I have to write little more test directly testing XSD specifications but this comes later. Have fun! Ralf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andrew and Jesper
I changed the cli based on your suggestions. You can have a look.
@jesper, I am not so familiar with the mvn antrun plugin but I added a class called 'TransformerTask' which is similar to the ReportTask you have mentioned. I hope you can reuse this class via ant.
What is not covered so far are:
Let me know what has to be improved on this version.
Cheers,
Ralf